Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update(github) Update github workflows #292

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Update(github) Update github workflows #292

merged 2 commits into from
Nov 17, 2023

Conversation

thePanz
Copy link
Member

@thePanz thePanz commented Nov 16, 2023 •
edited
Loading

  • include cache for composer installs
  • fix php-cs-fixer warnings

@thePanz thePanz force-pushed the update-github-workflow branch 4 times, most recently from 4470e8a to 79f007a Compare November 17, 2023 08:23
@thePanz thePanz changed the title Update(github) Update github workflows, include cache for composer in… Update(github) Update github workflows Nov 17, 2023
@thePanz
Copy link
Member Author

thePanz commented Nov 17, 2023

@thirsch @mentalstring OK to merge this?

my plan is to soon have php v7.4 as the min version, thus

  • have short array syntax as for doctrine1
  • later move to php v8.1 as min requirement

WDYT?

thirsch
thirsch approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@thirsch thirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as stated in the ticket about upgrading the php version, I'm fine with a new min version as everyone who needs an older version can stick to an older version of this repo.

I'd still not go for version 2, but 1.6 - composer wouldn't install it on platforms not matching the new requirement and for manual updaters, we should include a prominent "don't do it" somewhere in the readme.md

@thePanz
Copy link
Member Author

thePanz commented Nov 17, 2023 •
edited
Loading

LGTM, as stated in the ticket about upgrading the php version, I'm fine with a new min version as everyone who needs an older version can stick to an older version of this repo.

Yes, that's exactly the plan! 👍
As the efforts on this project are solely to make it working on newer versions of PHP without crashes or deprecations!

I'd still not go for version 2, but 1.6 - composer wouldn't install it on platforms not matching the new requirement and for manual updaters, we should include a prominent "don't do it" somewhere in the readme.md

The readme already has a "do not use this repo" line IIRC, and yes I would keep the versioning to 1.x.y , or even 1.5.x (to not go to v1.6 at all)

If you approve this PR I will merge it :)

@thirsch
Copy link
Collaborator

thirsch commented Nov 17, 2023

If you approve this PR I will merge it :)

Already done, but looks like my permissions are not sufficient ;)

@thePanz thePanz force-pushed the update-github-workflow branch from 79f007a to 7826e99 Compare November 17, 2023 11:03
@thePanz thePanz force-pushed the update-github-workflow branch from 7826e99 to 2a18a82 Compare November 17, 2023 13:22
@thePanz thePanz merged commit 2826410 into master Nov 17, 2023
5 checks passed
@thePanz thePanz deleted the update-github-workflow branch November 17, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thirsch thirsch thirsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thePanz @thirsch